Re: [cp-patches] [generics] RFC : implementation of java.lang.instrument package

[Mark Wielaard]

Hi Nicolas,

On Fri, 2005-11-25 at 12:03 -0700, Tom Tromey wrote:
> >>>>> "Nicolas" == Nicolas Geoffray <address@hidden> writes:
> 
> Nicolas> I implemented (implement is not really appropriate as it's minor 
> files
> Nicolas> with interfaces and exceptions) the java.lang.instrument.* files of
> Nicolas> the 1.5 API.
> 
> Awesome!

Very nice indeed :)

> Nicolas> Where this class should be : 
> Nicolas> gnu/java/lang/instrument/InstrumentationImpl.java?
> 
> Yes, that is the correct package to use.  The name of the class is
> less strictly defined by Classpath, but that name sounds fine to me.

Yes, that name is OK. I don't know how much we can actually share
between runtimes though. The interface is pretty minimal already, so a
split between VMInstrumentationImpl and InstrumentationImpl that calls
the VM class seems overkill. Do you think you can come up with something
that can easily be shared by runtimes? Maybe you could hook into the
default ClassLoader.defineClass() implementation to implement this?

Definitely a candidate for an extra section on the VM Integration guide!

Cheers,

Mark