classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] FYI: Added some real functionality to SystemFlavorMap


From: Jan Röhrich
Subject: Re: [cp-patches] FYI: Added some real functionality to SystemFlavorMap
Date: Tue, 29 Nov 2005 16:10:35 +0100

> > +  /**
> > +   * This map maps native <code>String</code>s to lists of 
> > +   * <code>DataFlavor</code>s
> > +   */
> > +  private Map nativeToFlavorMap = new HashMap();
> 
> It is better to use: private HashMap nativeToFlavorMap = new HashMap();
> As in most cases invocations on interface are slower then on direct
> classes.

oh, I didn't know that these method invocations are faster. But I prefer
a more generalized code style. Ok it's a private field so this may be no
problem in this case. 
But are there any other opinions on that or is this somewhere defined in
a GNU/Classpath Code style?

Regarding the other nitpicks :-) I'll correct them in one of my next
patches.

Greetings Jan

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil


reply via email to

[Prev in Thread] Current Thread [Next in Thread]