classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] Re: FYI: MetalFileChooserUI


From: Lillian Angel
Subject: [cp-patches] Re: FYI: MetalFileChooserUI
Date: Tue, 29 Nov 2005 16:12:58 -0500

Fixed npe.

2005-11-29  Lillian Angel  <address@hidden>

        * javax/swing/plaf/metal/MetalFileChooserUI.java
        (mouseClicked): Fixed checks to prevent NPE.



On Tue, 2005-11-29 at 15:21 -0500, Lillian Angel wrote:
> MetalFileChooserUI is pretty much completed now. I am still testing it
> for any remaining bugs. The sizing is still off in some cases, since the
> bug for wrapping JLists is not fixed (the wrapping code is temporarily
> commented out).
> 
> The details view works. Editing in all views also works.
> 
> 
> 
> 2005-11-29  Lillian Angel  <address@hidden>
> 
>         * javax/swing/JViewport.java
>         (setView): Added check to prevent NPE.
>         * javax/swing/plaf/basic/BasicFileChooserUI.java
>         (ListLabelRenderer): Removed class, never used.
>         * javax/swing/plaf/metal/MetalFileChooserUI.java
>         (DetailTableModel): Removed, not needed.
>         (TableFileRenderer): Implemented to override some color
>         and icon defaults in the default table renderer.
>         (actionPerformed): Set selection in list, if something was
>         selected in the table.
>         (actionPerformed): Set selection in table, if something was
>         selected in the list.
>         (propertyChange): Added code to set the selection for the table,
>         as well as the list. This depends on what view we are in.
>         (editFile): Fixed to call scrollRectToVisible instead.
>         (TableClickListener): Implemented new private class to take
>         care of double clicking (changing/opening directories/files)
>         and single clicking (editing).
>         (TableClickListener.mouseClicked): Implemented
>         (TableClickListener.editFile): Implemented
>         (TableClickListener.completeEditing): Implemented
>         (TableClickListener.EditingActionListener): Implemented
>         (TableClickListener.closeDialog): Implemented
>         (installListeners): Added code to initialize listener fields.
>         (uninstallListeners): Added code to uninstall all listeners.
>         (createList): Changed to use scrollPane field.
>         (createDetailsView): Changed to use updateTable function. Set
>         some characteristics for the table: column selection, renderer,
>         listener etc.
>         (updateTable): Implemented to changed/add/remove rows from the
>         table, as needed.
>         (removeControlButtons): Added repaint, revalidate calls.
>         (ensureFileIsVisible): Removed. Does the same thing as super.
>         (rescanCurrentDirectory): Added check for different views.
>         (setDirectorySelected): Removed. Does the same thing as super.
>         (getDirectoryName): Removed. Does the same thing as super.
>         (setDirectoryName): Removed. Does the same thing as super.
>         (valueChanged): Changed comment.
> 

Attachment: patch.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]