Re: [cp-patches] [generics] RFC : implementation of jjava.lang.instrument package

[Mark Wielaard]

Hi Nicolas,

On Fri, 2005-12-02 at 12:22 +0100, Nicolas Geoffray wrote:
> >Aha. Sorry I missed the dual nature of the
> >ClassFileTransFormer.transform() method. I see you documented this in
> >your original patch. In that case I really do think we should move these
> >to vm/reference/java/lang and make this method package private.
> >
> Which method? callTransformers? It's a method from the
> InstrumentationImpl class, therefore it's in
> gnu/java/lang/instrument. Would you like InstrumentationImpl
> to be in vm/reference/java/lang/InsutrumentationImpl? This sounds
> weird. We could also make the callTransformers method public.

Yes, but it makes it easier to share code with ClassLoader and
VMClassLoader if we do this. Then callTransformers doesn't have to be
public, but can just be package private. Then we don't have to worry
about whether or not someone can get insecure access to a
IntrumentationImpl (although I admit that is not very likely). It just
seems more natural to me to have all implementation classes in the same
package because they seem very related.

> I'm working on it (the jnjvm can now execute with the generics branch,
> yeah :)). OK for making suggestions, where should it be written?

In the VM Integration Guide of course and in the NEWS file. And when we
have a first implementation of all this checked in it might make sense
to explicitly ask on the main classpath list to get the attention of
those runtime implementors that don't follow the patches list that
closely.

Cheers,

Mark