classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] RFC : Instrumentation in the vm integration guide


From: Mark Wielaard
Subject: Re: [cp-patches] RFC : Instrumentation in the vm integration guide
Date: Sun, 04 Dec 2005 19:31:09 +0100

Hi Nicolas,

On Sun, 2005-12-04 at 16:20 +0100, Nicolas Geoffray wrote:
> 2005-12-04  Nicolas Geoffray  <address@hidden>
>                
>     * doc/vmintegration.texinfo: Added subsection in the classpath
>     hooks for the VMInstrumentationImpl class.

Thanks for writing this.

Two small comments:

> @@ -681,7 +682,43 @@
>  frames in the thread.  This depends on the deprecated method @code{suspend()}
>  having returned true, and is thus deprecated as a result.
>  @end itemize
> address@hidden itemize
> +
> address@hidden java.lang.VMInstrumentationImpl,, java.lang.VMThread, java.lang
> address@hidden @code{java.lang.VMInstrumentationImpl}

You accidentally removed a @end itemize.

> +No default implementation is provided in gnu classpath for the
> address@hidden method. A default implementation will perhaps
> +be written, but it might break the @code{ClassLoader/VMClassLoader} 
> interface.

Maybe explicitly say "for calling the
@code{InstrumentationImpl.callTransformers} when a class byte code is
defined with @code{ClassLoader.defineClass}"
So the vm implementer knows this is their job at the moment.

Please do check this in on the main cvs branch (trunk) so it is not just
in the generics branch documentation.

Thanks,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]