[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] [generics] RFC: fix generics branch compilation on Darw
From: |
Mark Wielaard |
Subject: |
Re: [cp-patches] [generics] RFC: fix generics branch compilation on Darwin |
Date: |
Mon, 05 Dec 2005 14:36:42 +0100 |
Hi Casey,
On Sun, 2005-12-04 at 21:56 -0800, Casey Marshall wrote:
> java_lang_VMSystem.c references 'extern char **environ,' which isn't
> defined on Darwin. java_lang_VMProcess.c has a little #if that
> defines this to a special function (_NSGetEnviron) for Darwin; the
> attached patch does the same for VMSystem.
>
> Does this look OK? I haven't tested this yet (I'm not entirely sure
> how to do so; I've heard that jamvm can run this branch, so I'm going
> to try that).
Yes, this looks OK. And it is similar to the patch on the trunk from
Chris for VMProcess.
2004-12-21 Chris Burdess <address@hidden>
* configure.ac: Check for presence of crt_externs.h on Darwin.
* native/jni/java-lang/java_lang_VMProcess.c: If HAVE_CRT_EXTERNS_H
is defined, define environ as calling _NSGetEnviron(), otherwise
define it as an external variable.
Please do check this in on the generics branch.
Cheers,
Mark
signature.asc
Description: This is a digitally signed message part