Re: [cp-patches] Patch: Allow Security.setProperty("foo", null)

[Tom Tromey]

>>>>> "Gary" == Gary Benson <address@hidden> writes:

Gary> The javadoc is unclear: it says nothing about null values, but it
Gary> doesn't say anything about throwing NullPointerExceptions (which we
Gary> currently do).  I tried it on a proprietary JVM and it accepted the
Gary> null pointer.  On the principle of accepting what you emit I think we
Gary> should do the same.

If you do a further getProperty() does it return null?
If so then this is fine.
Adding the test to mauve would be good.

Gary> + * java/security/Security.java (setProperty): Spelling correction.
Gary> + * java/security/Security.java (setProperty): Allow null values.

I would write just one entry like:

        * java/security/Security.java (setProperty): Allow null
        values.  Spelling correction.

How about adding a note to the javadoc about the handling of null
values?

Tom