classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] Patch: remove bogus ServerSocket security check


From: Tom Tromey
Subject: Re: [cp-patches] Patch: remove bogus ServerSocket security check
Date: 01 Jan 2006 10:05:39 -0700
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50

>>>>> "Mark" == Mark Wielaard <address@hidden> writes:

Mark> It is clear the current check is wrong since we check on the SocketImpl
Mark> of the ServerSocket and not the Socket that accept would return. But
Mark> wouldn't the correct security check just be to move this check just
Mark> after implAccept(socket) and then do the exact same check on the just
Mark> created socket?

Yeah, I think that would be correct.

Mark> Gary, do we have Mauve tests for this case already?

AFAIK we don't.  We do have a PR for this bug though.

Tom




reply via email to

[Prev in Thread] Current Thread [Next in Thread]