[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] RFC: JTextArea text == null in constructor patch
From: |
Roman Kennke |
Subject: |
Re: [cp-patches] RFC: JTextArea text == null in constructor patch |
Date: |
Tue, 03 Jan 2006 21:11:30 +0100 |
Hi Mark,
Am Dienstag, den 03.01.2006, 20:57 +0100 schrieb Mark Wielaard:
> Hi,
>
> While playing with JEdit I encountered an exception because JEdit has a
> JTextArea subclass that doesn't expect its overridden setText() method
> to be called from the constructor. This patch makes it so:
>
> 2006-01-03 Mark Wielaard <address@hidden>
>
> * javax/swing/JTextArea.java
> (JTextArea(Document,text,int,int)): Only call setText() when text is
> not null.
>
> I think this is OK since text is often null when any of the other
> constuctors is called that don't have a text argument (as in the JEdit
> case). Does it look sane?
Yes, please go ahead and commit it.
/Roman
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil