Re: [cp-patches] RFC: replacing jni_md-x86-linux.h by a generic jni_md.h

[Tom Tromey]

>>>>> "Dalibor" == Dalibor Topic <address@hidden> writes:

Dalibor> the attached patch replaces the os/cpu/toolchain specific
Dalibor> jni-md.h by a generic version that uses fixed size C99's
Dalibor> types to typedef java types. It's been successfully used in
Dalibor> Kaffe for a while.

I think there are 2 problems with this patch.

Dalibor> +#include "config-int.h"

First, we need jni_md.h to be installed.  This means that config-int.h
must be installed ... but it isn't.  And, simply installing it may be
wrong as it could redefine things like int8_t or whatever.

Dalibor> +/* Define some defaults */
Dalibor> +#define JNICALL
Dalibor> +#define JNIEXPORT
Dalibor> +#define JNIIMPORT

These aren't correct for Windows.  The old approach offered the
possibility of defining these correctly, at least in theory :-).

Tom