Re: [cp-patches] RFC: gnu.regexp fix to avoid unwanted PatternSyntaxException

[Mark Wielaard]

Hi,

On Fri, 2006-01-06 at 04:34 +0100, Dalibor Topic wrote:
> Ito Kazumitsu wrote:
> > This fixes the bug #25616.
> > 
> > I have updated the mauve test
> >   gnu/testlet/java/util/regex/Pattern/matches.java
> > for testing this fix.

Thanks! Please add the bug number to the ChangeLog/commit message so it
is automagically picked up by bugzilla (Add "Fixes bug #25616" at the
top).

> > ChangeLog:
> > 2006-01-05  Ito Kazumitsu  <address@hidden>
> > 
> >     * gnu/regexp/RE.java(initialize): Allow repeat.empty.token.
> > 
> >     * gnu/regexp/RETokenRepeated.java(match): Break the loop
> >     when an empty string matched an empty token.    
> > 
> > 
> 
> Thanks for the patch, Ito. Looks fine to me. I'd suggest removing 
> unnecessary code, rather then commenting it out, though.

Yes, please do remove dead code. Keeping a comment saying "Allow
repeat.empty.token" is OK, but having commented out code is confusing.

Thanks,

Mark

signature.asc
Description: This is a digitally signed message part