Re: [cp-patches] FYI: Define isnan explicitly in fdlibm

[Guilhem Lavaux]

Christian Thalinger wrote:
> On Sat, 2005-12-17 at 21:43 +0100, Guilhem Lavaux wrote:
>
> > Hi,
> >
> > Here is a patch to define isnan explicitly as a macro if it is not 
> > already defined. At the same it removes the symbol renaming in namespace.h.
>
>
> Hi!
>
> As i merged the changes into CACAO, i noticed that this patch breaks
> some stuff on mips-irix.  The fptest of the CACAO regression tests does
> not pass anymore:
>
>
> I didn't notice that earlier since i'm not using classpath cvs head on
> that machine.  What was the reason for this patch?

To define isnan in any cases. Looking at IRC logs it looks like that we 
met some trouble on darwin5. Here is a new patch which should make 
everyone happy.

Tell me if it's ok for you.

Cheers,

Guilhem.

Index: configure.ac
===================================================================
RCS file: /cvsroot/classpath/classpath/configure.ac,v
retrieving revision 1.123
diff -u -r1.123 configure.ac
--- configure.ac        4 Jan 2006 16:37:55 -0000       1.123
+++ configure.ac        12 Jan 2006 20:36:37 -0000
@@ -270,7 +270,8 @@
                  localtime_r \
                  strerror_r \
                   fcntl \
-                 mmap munmap mincore msync madvise getpagesize sysconf])
+                 mmap munmap mincore msync madvise getpagesize sysconf \
+                 isnan])
 
   AC_HEADER_TIME
   AC_STRUCT_TM
Index: native/fdlibm/fdlibm.h
===================================================================
RCS file: /cvsroot/classpath/classpath/native/fdlibm/fdlibm.h,v
retrieving revision 1.8
diff -u -r1.8 fdlibm.h
--- native/fdlibm/fdlibm.h      17 Dec 2005 20:46:57 -0000      1.8
+++ native/fdlibm/fdlibm.h      12 Jan 2006 20:36:37 -0000
@@ -96,7 +96,7 @@
 extern double gamma __P((double));
 extern double hypot __P((double, double));
 
-#ifndef isnan
+#if !defined(isnan) && !defined(HAVE_ISNAN)
 #define isnan(x) ((x) != (x))
 #endif