Re: [cp-patches] [generics] FYI: New Instrumentation parameter to VMInstrumentationImpl.redefineClasses

[Andrew John Hughes]

On Sat, 2006-01-14 at 03:13 +0100, Nicolas Geoffray wrote:
> Hi Andrew,
> 
> Andrew John Hughes wrote:
> 
> >On Sun, 2005-12-04 at 14:11 +0100, Nicolas Geoffray wrote:
> >  
> >
> >>Here's a fix that eases implementation of the 
> >>VMInstrumentationImpl.redefineClasses
> >>method. The VM might not want to keep the Instrument object, therefore 
> >>it must
> >>be given explicitely to the VMInstrumentationImpl.redefineClasses method
> >>
> >>2005-12-04  Nicolas Geoffray  <address@hidden>
> >>    
> >>    * vm/reference/java/lang/VMInstrumentationImpl.java
> >>    (redefineClasses): Added an extra parameter of type
> >>    java.lang.instrument.Instrument.
> >>    *java/lang/InstrumentationImpl.java
> >>    (redefineClasses): Added the Instrumentation object
> >>    to the arguments of VMInstrumentationImpl.redefineClasses
> >>    call.
> >>
> >>
> >>_______________________________________________
> >>Classpath-patches mailing list
> >>address@hidden
> >>http://lists.gnu.org/mailman/listinfo/classpath-patches
> >>    
> >>
> >
> >Am I missing something or is there a reason the code was only added to
> >the branch and not to HEAD?  From the patches, I don't see any 1.5
> >language features.
> >
> >  
> >
> Instrumentation is a 1.5 package feature. It's not part of the 1.4 
> specification. That's why
> the files are only in the branch.
> 
> Nicolas
> 
> 

But the branch isn't for 1.5 features as such.  It's for stuff that will
only compile when used with a compiler supporting the 1.5 features
(generics, enums, annotations and a few bits of syntactic sugar).  So,
if you can actually compile and run all the instrumentation stuff with a
1.4 suite, it should be on HEAD, IMHO.  At least, that was my
understanding of this and why it's called a generics branch and not a
1.5 branch -- someone correct me if I'm wrong.  There are quite a few
1.5 package features on HEAD already.

Thanks,
-- 
Andrew :-)

Please avoid sending me Microsoft Office (e.g. Word, PowerPoint)
attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html

If you use Microsoft Office, support movement towards the end of vendor
lock-in:
http://opendocumentfellowship.org/petition/

"Value your freedom, or you will lose it, teaches history.
`Don't bother us with politics' respond those who don't want to learn."
-- Richard Stallman

Escape the Java Trap with GNU Classpath!
http://www.gnu.org/philosophy/java-trap.html
public class gcj extends Freedom implements Java { ... }

signature.asc
Description: This is a digitally signed message part