[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] [generics] RFC: Genericize return type in PrinterStateR
Re: [cp-patches] [generics] RFC: Genericize return type in PrinterStateReasons
Sun, 15 Jan 2006 14:45:46 +0100
Debian Thunderbird 1.0.7 (X11/20051017)
Andrew John Hughes wrote:
On Sat, 2006-01-14 at 11:54 +0100, Wolfgang Baer wrote:
The patch looks fine to me; I think I already did some similiar edits on
this particular file when merging, so please make sure your patch is
against the latest version before committing.
Generally, I think these kind of edits are okay, but I'd save the
majority of it, where possible, to after the generics branch is
re-merged. There are cases where it has to be done, and I also don't
see any problem with fixing the bits that are part of the API (this is
especially important for those who worship JAPI). Additionally, it
could possibly catch the odd bug... though I've not seen it yet.
So I only committing the part of the API and just ignore the eclipse
warning for the stuff inside the method.
2006-01-15 Wolfgang Baer <address@hidden>
(printerStateReasonSet): Genericize the return type.
retrieving revision 18.104.22.168
diff -u -r22.214.171.124 PrinterStateReasons.java
--- PrinterStateReasons.java 10 Jan 2006 15:59:42 -0000 126.96.36.199
+++ PrinterStateReasons.java 15 Jan 2006 13:39:47 -0000
@@ -139,7 +139,7 @@
* @param severity the severity level for the constructed set.
* @return The set of printer state reasons.
- public Set printerStateReasonSet(Severity severity)
+ public Set<PrinterStateReason> printerStateReasonSet(Severity severity)
if (severity == null)
throw new NullPointerException("severity is null");