Re: [PATCH] attributed string fixes

[Guilhem Lavaux]

Mark Wielaard wrote:

> Hi,
>
> On Wed, 2003-11-19 at 16:03, Dalibor Topic wrote:
>  
>
> > graydon hoare wrote:
> >    
> >
> > > 2003-11-18  Graydon Hoare  <address@hidden>
> > >
> > >         * java/text/AttributedString.java: Fix arithmetic.
> > >         * java/text/AttributedStringIterator.java: Likewise.
> > >      
> > PLease take a look at Guilhem's patches to java.text first. Your patch 
> > fails with kaffe's version of the file for 3 hunks:
> >
> > patching file java/text/AttributedString.java
> > Hunk #3 FAILED at 407.
> > Hunk #4 FAILED at 217.
> > Hunk #5 FAILED at 266.
> > 3 out of 5 hunks FAILED -- saving rejects to file 
> > java/text/AttributedString.java.rej
> >    
>
> Dalibor is referring to following Classpath bugs:
> https://savannah.gnu.org/bugs/?func=detailbug&bug_id=4968&group_id=85
> https://savannah.gnu.org/bugs/?func=detailbug&bug_id=4118&group_id=85
>
> The first one has already been partly merged in and for the second bug
> Stephen Crawley already created some Mauve tests for the second case.
>
> I didn't have time to go through the complete patches yet and they don't
> apply cleanly anymore so updated patches are very welcome.
>
>  
I have quickly hacked a merge between current implementation and mine. 
The patch has been built using today's classpath CVS. If anybody can review it...
;-) I remind that this collator implements everything but one feature of Java's API 
('!' and some puzzling behaviour highlighted by 2 Mauve tests).

The new patch is available at:
https://savannah.gnu.org/bugs/?func=detailbug&bug_id=4118&group_id=85

The other one is following tomorrow or on friday... 

Regards,
Guilhem.