RE: Suggested Runtime change and small Thread fix

[Jeroen Frijters]

Mark Wielaard wrote:
> On Thu, 2003-11-20 at 12:17, Jeroen Frijters wrote:
> > I would like to move the code to run the shutdown hooks 
> from exit() to a
> > new method. This allows me to also run the shutdown hooks 
> if the process
> > termination is triggered by code outside of Java (in my .NET JVM). I
> > can't see it hurting any other scenarios.
> > 
> > Any objections or comments?
> 
> If this helps you then I see no objections.

OK. I checked them in.

> But we really should split Runtime into these kind of VM-independent
> methods and a VMRuntime that does the VM-dependent (memory,
> gc/finalizers, exec and halt) stuff.

Agreed, but that is (mostly) orthogonal to this patch. I'll try to do it
this weekend, it's been on my TODO list for a long time already ;-)

> > Also fixed Thread.start() to throw 
> IllegalThreadStateException instead
> > of IllegalStateException.
> 
> Funny the documentation was already correct.

It is easy to overlook the difference between the two class names. It
made me think that it would be nice to have a static analysis tool that
checks exceptions thrown vs caught. Such a tool would probably (as
usual) suffer from lots of false positives, but it might still be
helpful.

> BTW. Don't forget to update copyright years of files you change.

Thanks, I do tend to forget that.

BTW, I don't want to post a me too in the tab vs spaces thread, but
count me firmly in spaces camp. Tabs are a pain to manage.

Regards,
Jeroen