[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] enable Graphics2D at configure and runtime

From: Tom Tromey
Subject: Re: [PATCH] enable Graphics2D at configure and runtime
Date: 17 Dec 2003 10:27:29 -0700
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50

>>>>> "graydon" == graydon hoare <address@hidden> writes:

graydon> I'm sure there'll be a few suggestions about how "best" to do this, so
graydon> I just picked what seemed like an unintrusive method and implemented
graydon> it, to make sure it's even possible. any suggestions on how to do it
graydon> better?

I think adding a switch like this is fine.  Would it make sense to do
the check unconditionally and enable this code if the required
libraries are found?  Or is there a situation where you would want the
Gtk peers but not the Cairo code?

Overall I think this patch is fine.  I've got a new minor comments.

graydon> +if GTK_CAIRO
graydon> +lib_gnu_java_awt_peer_gtk_la_LIBADD = $(GTK_LIBS) $(GLIB_LIBS) 
$(LIBART_LIBS) -lcairo -lpixman -lpangoft2-1.0

Is there a pkg-config invocation or something to determine the
library names?  I'm thinking that ideally this would be run in
configure and then we would just have another possibly-empty variable
substitution in the definition of lib_gnu_java_awt_peer_gtk_la_LIBADD.

graydon> +    useGraphics2d = 
graydon> +                                       

I think we've been documenting all our properties somewhere.  I think
it is just in the javadoc for the class.  So, please add a javadoc
comment explaining this extension.

graydon> +  /* deprecated, part of the older AWT Toolkit API. */
graydon>    protected FontPeer getFontPeer (String name, int style) 

If this is really deprecated, mark it in javadoc:

    /** @deprecated reason */

Then it will show up in compilations.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]