[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ServerSocket.bind
From: |
Michael Koch |
Subject: |
Re: [PATCH] ServerSocket.bind |
Date: |
Thu, 25 Dec 2003 18:34:22 +0100 |
User-agent: |
Mutt/1.3.28i |
On Thu, Dec 25, 2003 at 06:18:51PM +0100, Michael Koch wrote:
> On Wed, Dec 24, 2003 at 04:40:34PM +0100, Guilhem Lavaux wrote:
> > Hi,
> >
> > It seems that nobody checks for null internet address in ServerSocket.bind.
> > Here is a quick fix which should prevent calling a native method with a
> > null address argument.
> >
> > Regards,
> > Guilhem.
> >
> > ChangeLog:
> >
> > 2003-12-24 Guilhem Lavaux <address@hidden>
> >
> > * java/net/ServerSocket.java (bind): Check whether the address is null.
> >
> > P.S.: I hope it can be applied to gcj (I've checked that the same code
> > is present there), the patch has been built upon kaffe's CVS.
>
> Two things: the patch is missing and the code uses a "instanceof"
> operator which implicitly checks for "null".
After talking with guilhem on irc I got the problem and wrote the
attached patch. I commited it to trunk already.
Mark: Can you please commit this to classpath ?
Michael
net.diff
Description: Text document