[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Classpathx-javamail] Patch Review: unused private methods
From: |
Conrad T. Pino |
Subject: |
[Classpathx-javamail] Patch Review: unused private methods |
Date: |
Wed, 28 Nov 2007 17:37:53 -0800 |
Patch goals:
1. Remove method is never used locally warnings, 3 in total.
2. Preserve unused methods in source until required, if ever.
Index: source/gnu/mail/providers/nntp/NNTPStore.java
===================================================================
RCS file:
/sources/classpathx/mail/source/gnu/mail/providers/nntp/NNTPStore.java,v
retrieving revision 1.17
diff -U 5 -r1.17 NNTPStore.java
--- source/gnu/mail/providers/nntp/NNTPStore.java 27 Nov 2007 22:03:55
-0000 1.17
+++ source/gnu/mail/providers/nntp/NNTPStore.java 29 Nov 2007 00:09:32
-0000
@@ -278,14 +278,16 @@
}
}
return -1;
}
+ /*
private boolean propertyIsFalse(String key)
{
return "false".equals(getProperty(key));
}
+ */
private boolean propertyIsTrue(String key)
{
return "true".equals(getProperty(key));
}
Index: source/gnu/mail/providers/nntp/NNTPTransport.java
===================================================================
RCS file:
/sources/classpathx/mail/source/gnu/mail/providers/nntp/NNTPTransport.java,v
retrieving revision 1.13
diff -U 5 -r1.13 NNTPTransport.java
--- source/gnu/mail/providers/nntp/NNTPTransport.java 27 Nov 2007 22:03:55
-0000 1.13
+++ source/gnu/mail/providers/nntp/NNTPTransport.java 29 Nov 2007 00:09:32
-0000
@@ -237,19 +237,21 @@
}
}
return -1;
}
+ /*
private boolean propertyIsFalse(String key)
{
return "false".equals(getProperty(key));
}
private boolean propertyIsTrue(String key)
{
return "true".equals(getProperty(key));
}
+ */
/*
* Returns the provider-specific or general mail property corresponding to
* the specified key.
*/
- [Classpathx-javamail] Patch Review: unused private methods,
Conrad T. Pino <=