[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Classpathx-javamail] Patch Review: unused local variables
|
From: |
Chris Burdess |
|
Subject: |
Re: [Classpathx-javamail] Patch Review: unused local variables |
|
Date: |
Thu, 29 Nov 2007 09:00:07 +0000 |
|
User-agent: |
Mutt/1.3.28i |
Conrad T. Pino wrote:
> Patch goals:
>
> 1. Remove local variable is never read warnings, 32 in total.
>
> Note: IMAPFolder retains "s.getConnection()" method call
> to preserve state change side effects, if any.
Yes, there are side effects. The patch seems fine.
--
Chris Burdess