commit-classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH] java.lang.Runtime split


From: Jeroen Frijters
Subject: RE: [PATCH] java.lang.Runtime split
Date: Sat, 27 Dec 2003 18:13:55 +0100

Hi, 

Mark Wielaard wrote:
> Thanks. But a few suggestions/tips:

Thanks. I'll try to do better next time.

> This does show a problem with autogenerated files though.
> My autogenerated version is different from yours.
> Which javah program did you use to generate your version with?

I manually changed the existing java_lang_Runtime.h, but you're right it
was incorrect. Your new version looks much better.

> I used gcjh (GCC) 3.3.3 20031206 (prerelease) (Debian).
> Maybe we shouldn't include them in CVS but autogenerate them always?

I just looked and some of the other header files are incorrect as well.
So at the very least it would be a good idea to regenerate them all, but
I would be in favor of removing them from cvs altogether.

Regards,
Jeroen




reply via email to

[Prev in Thread] Current Thread [Next in Thread]