coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[coreutils] [PATCH] maint: fix the fs-magic-compare rule


From: Jim Meyering
Subject: [coreutils] [PATCH] maint: fix the fs-magic-compare rule
Date: Mon, 17 May 2010 16:12:01 +0200

FYI, I noticed that this is required when "make fs-magic-compare"
failed, thanks to this relatively new feature of join and a not-quite
sorted input file:

    join: file 2 is not in sorted order
    make: *** [fs-magic-compare] Error 1
    [Exit 2]


>From 5e82d241d06b8bb887101b0f4f38e785b80e7fcf Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Mon, 17 May 2010 16:10:24 +0200
Subject: [PATCH] maint: fix the fs-magic-compare rule

* src/Makefile.am (fs-def): Sort definitions.
This is required by fs-magic-compare's use of join.
---
 src/Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index db5359b..4576d28 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -557,7 +557,7 @@ fs-magic-compare: fs-magic fs-kernel-magic fs-def

 CLEANFILES += fs-def
 fs-def: fs.h
-       grep '^# *define ' $< > $@-t && mv $@-t $@
+       grep '^# *define ' $< | $(ASSORT) > $@-t && mv $@-t $@

 # Massage bits of the statfs man page and definitions from
 # /usr/include/linux/magic.h to be in a form consistent with what's in fs.h.
--
1.7.1.250.g7d1e8



reply via email to

[Prev in Thread] Current Thread [Next in Thread]