[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [coreutils] [PATCH] maint: update sample test template

From: Eric Blake
Subject: Re: [coreutils] [PATCH] maint: update sample test template
Date: Fri, 01 Oct 2010 15:10:03 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100921 Fedora/3.1.4-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.4

On 10/01/2010 03:00 PM, Jim Meyering wrote:
-if test "$VERBOSE" = yes; then
-  set -x
-  FIXME --version

The VERBOSE=yes ->  "set -x" part is handled in, so it's
fine to remove that, but the other, --version-printing part...

It's intended to identify the program(s) under test so that we see in
the log whether it is indeed the just-compiled version or some other.
That particular problem doesn't arise very often, but when it has happened
before, it's been hard to diagnose.

Good point.

If we retain it, it would have to go *after* the path_prepend_ invocation.

     test "$VERBOSE" = yes&&  FIXME --version

What do you think?

I'll add that back to the template, and to the last few recently-added tests.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library

reply via email to

[Prev in Thread] Current Thread [Next in Thread]