coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [coreutils][patch] seq: User specified terminator


From: William Plusnick
Subject: Re: [coreutils][patch] seq: User specified terminator
Date: Thu, 28 Oct 2010 07:50:13 -0500



On Wed, Oct 27, 2010 at 2:40 PM, Jim Meyering <address@hidden> wrote:
I wrote that comment simply because I thought that
hard-coding "\n" might not always be desirable.
Given that no one has ever complained, so
simply removing the comment might be best.

Agreed, I couldn't think of a use for it. I just didn't want my short sightedness to potentially hinder someone else's work who did it. But I agree removing the line would be the best solution.

From cf0b0cbc14ffd42a8eb0170f95f1eca27836c7a2 Mon Sep 17 00:00:00 2001
From: Patrick W. Plusnick II <address@hidden>
Date: Wed, 27 Oct 2010 15:10:33 -0500
Subject: [PATCH] maint: I took a fixme that was no longer wanted out of seq.
 *src/seq: took out the comment asking for adding an option to specify the terminator string

---
 src/seq.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/seq.c b/src/seq.c
index c9bdf94..1db7665 100644
--- a/src/seq.c
+++ b/src/seq.c
@@ -46,7 +46,6 @@ static char const *separator;
 
 /* The string output after all numbers have been output.
    Usually "\n" or "\0".  */
-/* FIXME: make this an option.  */
 static char const terminator[] = "\n";
 
 static struct option const long_options[] =
--
1.7.1



reply via email to

[Prev in Thread] Current Thread [Next in Thread]