[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] split: fix cases where -n l/... creates extraneous files

From: Pádraig Brady
Subject: Re: [PATCH] split: fix cases where -n l/... creates extraneous files
Date: Wed, 25 May 2011 13:11:42 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20100227 Thunderbird/3.0.3

On 24/05/11 20:47, Jim Meyering wrote:
> Nice work.
> The only nit I see is that there's no reason to redirect stdout here,
> since it should be unused:
> diff --git a/tests/misc/split-lchunk b/tests/misc/split-lchunk
> index 762138b..12d76e8 100755
> --- a/tests/misc/split-lchunk
> +++ b/tests/misc/split-lchunk
> @@ -75,7 +75,7 @@ for ELIDE_EMPTY in '' '-e'; do
>        if test -z "$ELIDE_EMPTY"; then
>          split ---io-blksize=$IO_BLKSIZE $ELIDE_EMPTY -n l/2/$N in > chunk.k
> -        stat x* >/dev/null 2>/dev/null && fail=1
> +        stat x* 2>/dev/null && fail=1
>        fi
>        split ---io-blksize=$IO_BLKSIZE $ELIDE_EMPTY -n l/$N in

Good point.
Also if split does the wrong thing,
it will be better to have output for debugging.

I've fixed that along with another issue I
noticed with the previous patch. Attached.


Attachment: split-n-extra-file.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]