[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint: remove unneeded includes

From: Pádraig Brady
Subject: Re: [PATCH] maint: remove unneeded includes
Date: Fri, 03 Jun 2011 16:22:45 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20100227 Thunderbird/3.0.3

On 03/06/11 16:17, Eric Blake wrote:
> On 06/03/2011 09:06 AM, Pádraig Brady wrote:
>> On 03/06/11 15:52, Jim Meyering wrote:
>>> Nice.  Thanks!
>>> I haven't tried it yet.  How long does it take to run?
>>> Sounds like a good candidate to be run as a syntax-check rule.
>> It's awkward (relies on a llvm/clang source tree for example)
>> and currently requires human interpretation.
>> It basically takes as long as clang-analyzer does.
>> Not a candidate for automation at present.
> In other words, our existing sc_prohibit_XXX_without_use rules are
> faster at doing the job, once we take the time to write the rules for
> each header.
> Are any of the headers you cleaned up in your pass worth porting into
> gnulib's as new sc_prohibit_XXX_without_use rules?

Yes good point.
I was essentially doing this grepping to confirm
the redundancy anyway.
I'll look at update those rules later in the weekend.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]