coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils-8.12.178-df9cd on IRIX 6.5


From: Jim Meyering
Subject: Re: coreutils-8.12.178-df9cd on IRIX 6.5
Date: Fri, 02 Sep 2011 00:02:09 +0200

Bruno Haible wrote:

>> > > > On IRIX 6.5:
>> "make check" fails like this:
>
> But "cd tests; make check" gives at least a result:
>
> 8 of 304 tests failed
>
> FAIL: misc/pwd-long
> FAIL: misc/shuf
> FAIL: misc/sort-month
> FAIL: misc/sort-rand
> FAIL: misc/sort-version
> FAIL: cp/cp-parents
> FAIL: cp/fail-perm
> FAIL: cp/reflink-perm
>
> Find attached the tests/test-suite.log.

Thanks again!

On that system (perhaps combination of lack of working shell
and of diff program), we get almost no diagnostics.

At least this one is easy to understand/fix:

    FAIL: misc/pwd-long (exit: 1)
    =============================
    ./misc/pwd-long: configure did not find a usable version of Perl, so 
skipping this test
    ./misc/pwd-long[21]: Exit:  not found

Using "Exit" there is not valid.
Rather than simply tweaking the script to avoid
use of the Exit function which has not yet been defined,
I've opted to remove the require-perl file altogether.
That's in line with the test/file-to-function migration
we've been undergoing for a couple years now.


>From 01ba35f6a8e29f416b386e74eee07d5bd293afca Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 1 Sep 2011 23:59:02 +0200
Subject: [PATCH] tests: remove require-perl script; use function instead

* tests/require-perl: Remove file.
* tests/Makefile.am (EXTRA_DIST): Remove it from this list.
* tests/init.cfg (require_perl_): New function.
* tests/misc/pwd-long: Use the new function, not the file.
* tests/ls/nameless-uid: Likewise.
* tests/misc/sum-sysv: Likewise.
---
 tests/Makefile.am     |    1 -
 tests/init.cfg        |    8 ++++++++
 tests/ls/nameless-uid |    4 +---
 tests/misc/pwd-long   |    4 +---
 tests/misc/sum-sysv   |    5 ++---
 tests/require-perl    |    6 ------
 6 files changed, 12 insertions(+), 16 deletions(-)
 delete mode 100644 tests/require-perl

diff --git a/tests/Makefile.am b/tests/Makefile.am
index c37cca6..b920aba 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -18,7 +18,6 @@ EXTRA_DIST =          \
   init.sh              \
   lang-default         \
   other-fs-tmpdir      \
-  require-perl         \
   sample-test          \
   shell-or-perl                \
   $(pr_data)
diff --git a/tests/init.cfg b/tests/init.cfg
index 56df033..f7615e6 100644
--- a/tests/init.cfg
+++ b/tests/init.cfg
@@ -335,6 +335,14 @@ require_dirent_d_type_()
     || skip_ requires d_type support
 }

+# Skip the current test if we lack Perl.
+require_perl_()
+{
+  : ${PERL=perl}
+  $PERL -e 'use warnings' > /dev/null 2>&1 \
+    || skip_ 'configure did not find a usable version of Perl'
+}
+
 # Does the current (working-dir) file system support sparse files?
 require_sparse_support_()
 {
diff --git a/tests/ls/nameless-uid b/tests/ls/nameless-uid
index 4952103..9b81392 100755
--- a/tests/ls/nameless-uid
+++ b/tests/ls/nameless-uid
@@ -16,13 +16,11 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.

-: ${srcdir=.}
-. $srcdir/require-perl
-
 . "${srcdir=.}/init.sh"; path_prepend_ ../src
 print_ver_ ls

 require_root_
+require_perl_

 nameless_uid=`$PERL -e '
   foreach my $i (1000..16*1024) { getpwuid $i or (print "$i\n"), exit }
diff --git a/tests/misc/pwd-long b/tests/misc/pwd-long
index e318457..bf088fb 100755
--- a/tests/misc/pwd-long
+++ b/tests/misc/pwd-long
@@ -17,13 +17,11 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.

-: ${srcdir=.}
-. $srcdir/require-perl
-
 . "${srcdir=.}/init.sh"; path_prepend_ ../src
 print_ver_ pwd

 require_readable_root_
+require_perl_

 ARGV_0=$0
 export ARGV_0
diff --git a/tests/misc/sum-sysv b/tests/misc/sum-sysv
index 0e35ad3..f4d6a18 100755
--- a/tests/misc/sum-sysv
+++ b/tests/misc/sum-sysv
@@ -16,9 +16,6 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.

-: ${srcdir=.}
-. $srcdir/require-perl
-
 # Avoid a problem when run in a UTF-8 locale.
 # Otherwise, Perl would try to (and fail to) interpret
 # each string below as a sequence of multi-byte characters.
@@ -28,6 +25,8 @@ export LC_ALL
 . "${srcdir=.}/init.sh"; path_prepend_ ../src
 print_ver_ sum

+require_perl_
+
 # FYI, 16843009 is floor (2^32 / 255).

 # aka: perl -e 'print chr(255) x 16843009'
diff --git a/tests/require-perl b/tests/require-perl
deleted file mode 100644
index a6d9dc9..0000000
--- a/tests/require-perl
+++ /dev/null
@@ -1,6 +0,0 @@
-: ${PERL=perl}
-$PERL -e 'use warnings' > /dev/null 2>&1 || {
-  echo 1>&2 "$0: configure did not find a usable version of Perl," \
-    "so skipping this test"
-  Exit 77
-}
--
1.7.7.rc0.362.g5a14



reply via email to

[Prev in Thread] Current Thread [Next in Thread]