Re: Fwd: Re: [Platform-testers] new snapshot available: coreutils-8.12.178-df9cd

[Jim Meyering]

Jim Meyering wrote:
...
> Thanks.  I'll review one more time and apply these post-release.

Thanks for your patience.
I have applied those two change-sets with some minor changes:
  - we prefer to use "ATTRIBUTE_UNUSED" to mark unused variables
  - I removed the backslashes and added quotes in the check for
      _nomembers functions.  Yes, the (old!) code just above needs the
      same treatment, which I'm about to provide.
    

diff --git a/src/chroot.c b/src/chroot.c
index 4c56bf3..8bd39fc 100644
--- a/src/chroot.c
+++ b/src/chroot.c
@@ -57,10 +57,8 @@ static struct option const long_opts[] =
    always-successful replacement to avoid checking for setgroups
    availability everywhere, just to support broken platforms. */
 static int
-setgroups(size_t size, gid_t const *list)
+setgroups (size_t size ATTRIBUTE_UNUSED, gid_t const *list ATTRIBUTE_UNUSED)
 {
-  (void)size;
-  (void)list;
   return 0;
 }
 #endif

 
diff --git a/m4/jm-macros.m4 b/m4/jm-macros.m4
index a6de8f1..dc68f3b 100644
--- a/m4/jm-macros.m4
+++ b/m4/jm-macros.m4
@@ -89,14 +89,15 @@ AC_DEFUN([coreutils_MACROS],
     tcgetpgrp \
   )

-  # those checks exists for interix, where there are blazingly fast
-  # replacements for some functions, that don't query the domain
-  # controller for user information where it is not needed.
-  AC_CHECK_FUNCS_ONCE( \
-    getgrgid_nomembers \
-    getgrnam_nomembers \
-    getgrent_nomembers \
-  )
+  # These checks are for Interix, to avoid its getgr* functions, in favor
+  # of these replacements.  The replacement functions are much more efficient
+  # because they do not query the domain controller for user information
+  # when it is not needed.
+  AC_CHECK_FUNCS_ONCE([
+    getgrgid_nomembers
+    getgrnam_nomembers
+    getgrent_nomembers
+  ])

   dnl This can't use AC_REQUIRE; I'm not quite sure why.
   cu_PREREQ_STAT_PROG