[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: adjust PATH to include /usr/sbin for filefrag-using t
From: |
Pádraig Brady |
Subject: |
Re: [PATCH] tests: adjust PATH to include /usr/sbin for filefrag-using tests |
Date: |
Wed, 23 Nov 2011 09:28:52 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0 |
On 11/23/2011 09:17 AM, Jim Meyering wrote:
> Bernhard Voelker wrote:
>> Although my OpenSuSE system has e2fsprogs installed, the test
>> fiemap-perf cannot use it, because /usr/sbin is missing in
>> my (non-root) user's PATH:
>>
>> fiemap-perf: skipped test: the `filefrag` utility is missing
>> SKIP: cp/fiemap-perf
>>
>> This is similar to the matter in commit
>> 5eeaca942ab8fc090cd6b0ae2fede698dc9a6f5d.
>>
>> The attached patch fixing it (although I feel that we may
>> need a more generic function require_sbin_tool_).
>
> I have reservations about this, like I had for the other
> commit you mention. IMHO, that your sudo does not include /sbin
> or /usr/sbin in PATH is a bug.
>
> My first reaction is that every application should not be trying to work
> around that bug. That would be, in a way, condoning the bug.
> The real way to work around it is on a system-wide basis.
>
> Other opinions?
I have to concur.
I never got the whole separate /sbin thing anyway.
For sudo path issues I found this helped:
alias sudo='sudo env PATH=$PATH'
cheers,
Pádraig.
- [PATCH] tests: adjust PATH to include /usr/sbin for filefrag-using tests, Bernhard Voelker, 2011/11/23
- Re: [PATCH] tests: adjust PATH to include /usr/sbin for filefrag-using tests, Jim Meyering, 2011/11/23
- Re: [PATCH] tests: adjust PATH to include /usr/sbin for filefrag-using tests,
Pádraig Brady <=
- Re: [PATCH] tests: adjust PATH to include /usr/sbin for filefrag-using tests, Bernhard Voelker, 2011/11/23
- Re: [PATCH] tests: adjust PATH to include /usr/sbin for filefrag-using tests, Erik Auerswald, 2011/11/23
- Re: [PATCH] tests: adjust PATH to include /usr/sbin for filefrag-using tests, Jim Meyering, 2011/11/23
- Re: [PATCH] tests: adjust PATH to include /usr/sbin for filefrag-using tests, Bernhard Voelker, 2011/11/23
- Re: [PATCH] tests: adjust PATH to include /usr/sbin for filefrag-using tests, Bob Proulx, 2011/11/23
- Re: [PATCH] tests: adjust PATH to include /usr/sbin for filefrag-using tests, Bernhard Voelker, 2011/11/24
- Re: [PATCH] tests: adjust PATH to include /usr/sbin for filefrag-using tests, Erik Auerswald, 2011/11/24
- Re: [PATCH] tests: adjust PATH to include /usr/sbin for filefrag-using tests, Bob Proulx, 2011/11/27
- Re: [PATCH] tests: adjust PATH to include /usr/sbin for filefrag-using tests, Bob Proulx, 2011/11/27
- RE: [PATCH] tests: adjust PATH to include /usr/sbin for filefrag-using tests, Voelker, Bernhard, 2011/11/28