[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: add a syntax check for last week's global change

From: Eric Blake
Subject: Re: [PATCH] tests: add a syntax check for last week's global change
Date: Mon, 28 Nov 2011 14:14:17 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0

On 11/28/2011 12:18 PM, Jim Meyering wrote:
>> That is, any objections to moving this out of coreutil's and into
>> gnulib's
> I was reluctant to do that because "compare" is a pretty common word,
> and I didn't try to limit the rule to a particular (tests/) directory.
> If it works in libvirt with no false positives, that is a pretty good
> indication that we don't need to worry about them just yet.

Ah, but $(_sc_search_regexp) already supports the notion of
containing=... as a way of filtering to just files that contain
'', and thus limiting things to files that actually use compare()

> If it comes to that, we could limit the rule to packages that have
> gnulib's

Yep, I plan on doing that as part of the move.

> So, yes, this is fine with me.
> Welcome actually, so we'll benefit also via grep, diffutils, parted,
> etc., without having to add to their local files.
> Thanks.
> You're welcome to remove it from coreutils', too.

Okay, I'm now in the middle of coding up the move, and will post and
push the patches if results look reasonable with libvirt.

Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]