[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] test: expose recent gnulib canonicalize bug

From: Eric Blake
Subject: Re: [PATCH] test: expose recent gnulib canonicalize bug
Date: Wed, 08 Feb 2012 09:14:54 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0

On 02/08/2012 03:24 AM, Pádraig Brady wrote:
> On 02/07/2012 12:33 AM, Eric Blake wrote:
>> detailed a couple of bugs in gnulib's canonicalize that were visible
>> through coreutils' readlink, but only on systems where // is distinct
>> from /.  This particular test assumes that POSIX will be fixed to
>> require canonicalization of a symlink containing just slashes will
>> behave as if slashes separating the symlink from the rest of the
>> name are elided (see,
>> as that is the only useful (and current) behavior on Cygwin.  That is,
>> ln -s / root
>> ls root/dev
>> must list the contents of /dev, not //dev.

>> +
>> +test -d /dev || framework_failure_
> Maybe just skip_ above?

Nah.  POSIX requires /dev/null to exist, and you'd be hard-pressed to
find a system where this test fails.

> cool.

Good to hear; that means I now need to write up my realpath test for //.

Question before I push:  Right now, we have:


This feels inconsistent; should we be consolidating all readlink-related
tests into the same directory, and if so, which directory?

Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]