[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: "ls -l": Avoid unnecessary getxattr() overhead

From: Jim Meyering
Subject: Re: "ls -l": Avoid unnecessary getxattr() overhead
Date: Mon, 20 Feb 2012 13:50:29 +0100

Pádraig Brady wrote:
> On 02/19/2012 05:00 PM, Jim Meyering wrote:
>> Pádraig Brady wrote:
>>> Also I was a bit surprised to see EBUSY and ENOENT in errno_unsupported().
>>> Can one assume there are no other attributes on a device if you get those?
>> I added those to align with ACL_NOT_WELL_SUPPORTED from
>> lib/acl-internal.h, but now that you mention it, I suppose we'll need
>> different errno-checking functions for ACL-related than for getfilecon
>> failures.  I suppose ENOENT can arise when the file is removed between
>> when we stat'd it and when we perform one of these three file-name-using
>> tests.
> OK to push this so?

Yes.  Thank you!

> commit 7f48aa570d93347aa72d86a034e36377db6a22b9
> Author: Pádraig Brady <address@hidden>
> Date:   Mon Feb 20 12:33:17 2012 +0000
>     ls: adjust errnos indicating device non support for xattrs
>     * src/ls.c (errno_unsupported): Remove EBUSY, as this caters for
>     the case where ACLs can't be accessed because the _file_ is locked.
>     Also ENOENT is not safe to include as you get that if the _file_
>     is removed between the stat() and subsequent querying of xattrs.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]