[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: success! [Re: [PATCH 22/22] maint: avoid distcheck failure...

From: Jim Meyering
Subject: Re: success! [Re: [PATCH 22/22] maint: avoid distcheck failure...
Date: Sat, 01 Sep 2012 21:44:59 +0200

Thank you.
I took all of your suggestions but one.

Stefano Lattarini wrote:
>> [PATCH 05/25] maint: improve remake rules for maintainers
>> This is a follow up on today's former commit "build: refactor
>> how lists of coreutils programs are defined".
> Once the series has stabilized, here we could add a reference to
> the 'git-describe' output of that commit.  Probably overly picky
> though; I leave it to you to decide whether such tweaking is worth
> or not.

No trouble.  I've done that.

>> [PATCH 12/25] build: one less unneeded make variable
>> * man/ (man_aux): This was used only once, so inline its
>> expansion at its only point of use ...
> s/at its only point of use/in the only place where it is used/ maybe?

I'd already adjusted that one, changing something involving "in ..." to the
"at its ..." wording, so of course, I think the current wording is fine ;-)
However, changing s/only/sole/ does make it a little better, so I've
done that.

>> (EXTRA_DIST): ... here.
>>From 8624cc107691542cf0d10fc8934609c4d0d863ba Mon Sep 17 00:00:00 2001
> From: Stefano Lattarini <address@hidden>
> Date: Sat, 1 Sep 2012 01:46:50 +0200
> Subject: [PATCH 13/25] build: rename dist_man1_MANS -> man1_MANS
>> And list $(man1_MANS) directly in $(EXTRA_DIST) instead.
>> This offers more similarity to what is done for $(EXTRA_MANS)
> I'd substitute this sentence with:
>     This is similar to what is done for $(EXTRA_MANS), thus
>     improving consistency and readability.

I prefer that, too.

>> [PATCH 19/25] maint: port manpages generation to VPATH builds
>> * man/ (.x.1): Use '$(MKDIR_P)' rather than bare 'mkdir'
>> where appropriate.
>> Reported-by: Jim Meyering <address@hidden>
> You might want to delete this 'Reported-by:', if I remember your
> preferences correctly

Yes.  Thanks.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]