[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cp preserves mode with --no-preserve=mode

From: Ondrej Oprala
Subject: Re: cp preserves mode with --no-preserve=mode
Date: Wed, 05 Sep 2012 13:40:24 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0

On 08/07/2012 05:37 PM, Bernhard Voelker wrote:
On 08/07/2012 05:01 PM, Ondrej Oprala wrote:
Hi, I've renamed the variable to be more hinting of it's purpose
and --no-preserve=mode should now work properly with directories
as well.
Thanks, that looks good ... maybe the directory case deserves to
be added to the test. Minor nit: the change in copy_internal() is
missing in the commit log.
I'm sure that Padraig/Jim will add both when committing.

BTW: Interestingly, the TODO entry mentioned "--no-preserve=X"
to be buggy:

-cp --no-preserve=X should not attempt to preserve attribute X
-  reported by Andreas Schwab
but in fact, all the modes (t,o,l,c, and x) but "mode"
have already been working. ;-)

Have a nice day,
Hi, I've amended the commit log and added a test for directories.

Attachment: DIFF
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]