Re: [PATCH]: uniq: add tests for "--ignore-case"

[Assaf Gordon]

Pádraig Brady wrote, On 02/27/2013 10:38 PM:
> On 02/12/2013 03:44 PM, Assaf Gordon wrote:
>> I noticed that by running the default test suite ("make check SUBDIRS=."), 
>> the majority of uniq tests are skipped:
>>   uniq: skipping this test -- no appropriate locale
>>   SKIP: tests/misc/uniq.pl
>>   PASS: tests/misc/uniq-perf.sh
>>
>> This is due to tests/misc/uniq.pl line 83:
>>  83 # I've only ever triggered the problem in a non-C locale.                
>>        
>>  84 my $locale = $ENV{LOCALE_FR};                                            
>>        
>>  85 ! defined $locale || $locale eq 'none'                                   
>>        
>>  86   and CuSkip::skip "$prog: skipping this test -- no appropriate 
>> locale\n";      
>>
>> which skips the entire suite if there's no french locale defined, even 
>> though only one test actually sets the locale.
>>
>> I can have a patch for it, if that's acceptable.
> 
> Thanks for noticing that.
> A patch would be much appreciated.
> 

Attached a patch to not-skip all uniq tests if french locale is missing.

-gordon

0001-uniq-don-t-skip-all-tests-when-locale-is-missing.patch
Description: Text Data