[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: fix false failure on systems without /dev/stdin
|
From: |
Pádraig Brady |
|
Subject: |
Re: [PATCH] tests: fix false failure on systems without /dev/stdin |
|
Date: |
Mon, 09 Dec 2013 14:47:57 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 12/09/2013 02:42 PM, Bernhard Voelker wrote:
> On 12/09/2013 02:17 PM, Pádraig Brady wrote:
>> * tests/rm/interactive-once.sh: Ensure the expected output
>> matches with the output on systems without /dev/stdin (like AIX 7).
>> Also change some fail=1 to a more appropriate framework_failure_.
>
> Looking at the test again - why do we check for /dev/stdin at all?
> I mean, the test uses "rm ---presume-input-tty ..." anyway.
Fair point. It was mainly for consistency with
other tests that checked /dev/stdin.
We can adjust this after if required anyway.
thanks,
Pádraig.