coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] df: avoid stat() for dummy file systems with -l


From: Kamil Dudka
Subject: Re: [PATCH] df: avoid stat() for dummy file systems with -l
Date: Tue, 01 Aug 2017 10:02:07 +0200
User-agent: KMail/4.14.10 (Linux/4.9.34-gentoo; KDE/4.14.32; x86_64; ; )

On Tuesday, August 01, 2017 01:54:56 Bernhard Voelker wrote:
> The attached fixes a hang for unaccessible NFS mounts which
> are automounted by systemd.

The summary mentions 'df -l', which is mapped to the show_local_fs flag.  
However, the condition you are adding does not use the flag at all.  Why?

The condition already contains a special handling for 'df -l':

    (me->me_remote && show_local_fs)

Why does not it work without your patch?

How exactly looks the mount entry you want to skip the stat() call for?

What is the full content of *me in this case?

Is there a good reason for http://bugzilla.suse.com/show_bug.cgi?id=1043059 
not being accessible for free?

Kamil

> See e.g.
>   http://blog.tomecek.net/post/automount-with-systemd/
> for how to configure such a systemd unit to reproduce.
> 
> Do we need a test case for this?
> 
> Have a nice day,
> Berny



reply via email to

[Prev in Thread] Current Thread [Next in Thread]