[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: ls.c: apply _GL_ATTRIBUTE_PURE to more functions
|
From: |
Jim Meyering |
|
Subject: |
Re: [PATCH] build: ls.c: apply _GL_ATTRIBUTE_PURE to more functions |
|
Date: |
Sun, 29 Oct 2017 14:48:44 -0700 |
On Sun, Oct 29, 2017 at 2:25 PM, Pádraig Brady <address@hidden> wrote:
> On 27/10/17 21:37, Jim Meyering wrote:
>> I noticed a new warning/error when building with git-latest gcc,
>> and propose to fix it with this:
>>
>>>From f89c20bdf7ccc033cbc22662e932fae7761754fc Mon Sep 17 00:00:00 2001
>> From: Jim Meyering <address@hidden>
>> Date: Fri, 27 Oct 2017 21:14:37 -0700
>> Subject: [PATCH] build: ls.c: apply _GL_ATTRIBUTE_PURE to more functions
>>
>> * src/ls.c (DEFINE_SORT_FUNCTIONS): Apply _GL_ATTRIBUTE_PURE
>> to each strcmp-derived function definition, since GCC8 with
>> -Wsuggest-attribute=pure now warns it is needed.
>
> +1
> Works fine with gcc 6.3.1 FWIW
Thanks. Pushed.