Re: [PATCH] base64: fix 'extra operand' error message

[Assaf Gordon]

Hello Berny and all,

On 2018-12-19 7:26 a.m., Bernhard Voelker wrote:
> On 12/19/18 9:10 AM, Assaf Gordon wrote:
> > I noticed this small issue in base64 (seems the code is from
> > the original commit in 2006 when switching to git).
> Nice catch!

Thanks for the quick reviewing!

> Comments:
> * a test may be good, wouldn't it?

Test is always a good idea, attached updated patch with tests.


> * base32 is affected, too.  It's the same source, but the fix should
>    be mentioned for both programs.
> * this is a user-visible change, therefore it deserves a NEWS entry.

This is a tiny change in the error message - not sure it warrants
a NEWS entry - it went 12 years with no one noticing or complaining :)

As for base32, I see two commits for base64 (that happened after adding
base32), and they don't mention base32 despite affecting it as well:

* df3b9120b base64: no longer support hex or oct --wrap params
* a8cc9ce3f base64: use stricter validation on wrap column

I don't have strong feeling either way (adding NEWS and mention base32
or not), happy to send another patch with those if you think they are 
needed. should we support git commit message with "base64/32" prefix?



regards,
 - assaf

0001-base64-fix-extra-operand-error-message.patch
Description: Text Data