csnippets-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [CSnippets-dev] build.sh BSD tweaks patch


From: Allan Ference
Subject: Re: [CSnippets-dev] build.sh BSD tweaks patch
Date: Fri, 9 Aug 2013 14:09:12 +0200

Hi Ernesto,

I can't apply your patch because:
$ git am --signoff < csnippets-bsd_build.sh_tweaks.patch
Patch does not have a valid e-mail address.

Also, you forgot to sign it off, please do so.
One small note: you did:
+OPSYS=$(uname -s) at the beginning of the file then later on you did the same thing, was that intended?
Thanks!


On Wed, Aug 7, 2013 at 7:40 AM, Ernesto Celis <address@hidden> wrote:
Hi!

Attached you will find an small patch to enable build of csnippets in
both, FreeBSD 9.1 x86 and NetBSD 6.0.1 amd64. Bash is not installed by
default neither in FreeBSD nor NetBSD, so I had to install it from ports
and changed hash-bang line ; I had to add a couple of variables ARCH and
OPSYS mainly to avoid geting lost when switching betwen systmes but
these also help to identify stuff available across systems.

The patch is a git diff output, it also includes a small modification to
src/CMakeLists.txt which wasn't intended to be included but it is
harmless so I let it go.
-Wno-unused-result is unkown in GCC < 4.4

The build is succesful in my Xubuntu system, but still fails in both BSD
systems, today I'll take a look to build log files and see if I can get
beyond 11~17%.

-- SDF Public Access UNIX System http://ecelis.sdf.org -
gopher://sdf.org/1/users/ecelis +1 206-299-2120 ext.1106 - C*Net
1-333-1106



--
Allan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]