[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Cvs-cvs] ccvs/src ChangeLog admin.c
From: |
Larry Jones |
Subject: |
Re: [Cvs-cvs] ccvs/src ChangeLog admin.c |
Date: |
Tue, 13 Jun 2006 15:37:44 -0400 (EDT) |
Derek Robert Price writes:
>
> Index: admin.c
> ===================================================================
> RCS file: /cvsroot/cvs/ccvs/src/admin.c,v
> retrieving revision 1.115
> retrieving revision 1.116
> diff -u -b -r1.115 -r1.116
> --- admin.c 9 Jun 2006 21:28:17 -0000 1.115
> +++ admin.c 13 Jun 2006 19:26:43 -0000 1.116
> @@ -339,7 +339,7 @@
> static size_t
> wescape(char *dst, const char *src)
> {
> - const unsigned char *s = src;
> + const char *s = src;
> char *d = dst;
> for (; *s; s++) {
> if (!isprint (*s) || isspace (*s) || *s == '|') {
Wrong fix, Derek. The is*() functions want unsigned chars, so you
shouldn't change the type of s. Either add an explicit cast to the
initialization or change the type of src -- it just depends how far
upstream you want to push the changes.
-Larry Jones
Hey Doc, for 10 bucks I'll make sure you see those kids in the
waiting room again real soon! -- Calvin