[Cvs-dev] Re: cvs-passwd patch

[Mark D. Baushke]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Prasad J Pandit <address@hidden> writes:

> > Have you tried to configure --disable-client
> > and had it work? If so, how did the
> 
>    No, I've not. What is it, btw ?!!?

Some sites provide a server-only instance of cvs.
This is created using './configure
- --disable-client' ... other folks have a
client-only instance of cvs. This is created using
'./configure --disable-server' and some folks only
want to have a cvs that works locally. They use
both of the --disable-client and --disable-server
switches.

> > To be honest, there were many other problems
> > with your initial offering and I was more
> > concerned about the protocol you were
> > proposing than I was about the implementation
> > you were attempting. I also tried to give you
> > guidelines about coding style and tests.
> 
>    I understand that. but still, you should've
> had, at least, hinted me about hash.c and stuff.

I honestly didn't notice that you were using a
linked list in your previous code.

I have also not yet looked to see if your protocol
extension would really be interoperable with the
CVSNT protocol or not. Part of this is that I have
not yet compiled your code with success.

I actually doubt it will work, because you never
actually check to see if 'passwd' is a
supported_request() or not. Nor do you specify a
separate supported_request() optoin to see if the
encryption option is supported or not by the server.

I believe either Derek or I or both of us have
mentioned this in previous e-mail, but you
apparently do not understand what has been
communicated.

I can tell you right now that your patch will not
be accepted without those checks, so you might as
well figure out how to do them before you send the
next one for review.

You may find it useful to look at the src/ls.c
file and src/server.c for examples of how to add
an appropriate REQ_LINE() for an option to help
you in this. I suspect you are going to want a

REQ_LINE("passwd-encrypt-option", serve_noop, RQ_ROOTLESS),

or some such option name to specify that the
server supports your new '-e' switch.

Remember that you should assume that a CVSNT client
may be talking to your server or vice versa.

> > If you want another drop of the top-of-tree
> > sources at some point, let me know. It has
> > drifted a bit from the 1.12.13 release you are
> > using.
> 
>    Yep, that'll be better.
> 
> Thank you! :)

A URL to download the latest sources has been sent
as in a separate messasge.

        -- Mark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (FreeBSD)

iD8DBQFFF7m4Cg7APGsDnFERAlNrAKDJlfaCJ6NV6313+cNm4AwB91b+uwCgw/T0
/okhJ7SgM+KIx2b0MgWe6RA=
=ULt7
-----END PGP SIGNATURE-----