[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch: baseboard_SCRIPTS missing files

From: Ben Elliston
Subject: Re: patch: baseboard_SCRIPTS missing files
Date: Mon, 11 Feb 2008 22:27:39 +1100
User-agent: Mutt/1.5.13 (2006-08-11)

Hi H-P

> that this is documented as a deliberate omission.  (See the automake
> FAQ; it's along the lines of with such a feature, it'd be easy to
> omit or distribute files by mistake.  Just silly, if you ask me.)

Yes, agreed.

> I'm not sure how you wish to handle the problem of not introducing
> these inconsistencies in the future.  If it were up to me, I'd just
> require GNU make and replace that line with "baseboards_SCRIPTS =
> $(wildcard baseboard/*.exp)" or replace the hard list with the
> equivalent autoconf-replaced list.  Or at least add a check-local
> clause checking that the hard list equals "ls baseboards/*.exp"
> (after sorting, etc.)

I would normally have checked this closer to release time, by doing a
make install and visually inspecting the install tree.  However,
having a testsuite test that checks for this seems like a good
compromise to me.  Would you be willing to submit that, too?

> 2008-02-11    <address@hidden>
>       * (baseboard_SCRIPTS): Add scripts cris-sim.exp,
>       iq2000-sim.exp and m32r-linux-sim.exp.
>       * Regenerate.

Checked into the git tree, thanks.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]