Re: Set environment variable on remote target

[Andreas Schwab]

Jie Zhang <address@hidden> writes:

> Andreas Schwab wrote:
>> Jie Zhang <address@hidden> writes:
>>
>>> @@ -261,7 +262,11 @@ proc rsh_exec { boardname program pargs inp outp } {
>>>     set inp "/dev/null"
>>>      }
>>>  -    set ret [local_exec "$RSH $rsh_useropts $hostname sh -c '$program
>>> $pargs \\; echo XYZ\\\${?}ZYX'" $inp $outp $timeout]
>>> +    set remote_envs ""
>>> +    foreach envvar [array names remote_env] {
>>> +   set remote_envs "$remote_envs $envvar=$remote_env($envvar)"
>>
>> That needs to do proper quoting to protect shell meta characters.
>>
> Thanks for pointing out this. A new patch is attached. Is the quoting right?

That won't protect all meta characters.  Inside double quotes the dollar
sign, backslash and backquote are still special.

Andreas.

-- 
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."