[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Denemo-devel] memory leak
From: |
Richard Shann |
Subject: |
[Denemo-devel] memory leak |
Date: |
Tue, 08 Mar 2011 08:18:58 +0000 |
Jeremiah - your latest check-in leaks memory I think.
strip_path_and_extension (filename) needs to be freed (in fact, the
original code also leaked memory: g_path_get_basename (filename) is a
newly allocated string, and so needs to be freed.
Richard
+static gchar *
+strip_path_and_extension (gchar *filename) {
+ gchar *name;
+ name = g_path_get_basename (filename);
!!!!!this is new memory on heap
+ return strtok(name, ".");
+}
+
static void
update_file_selection_path (gchar *file) {
if(file_selection_path)
@@ -263,7 +270,7 @@ open_for_real (gchar * filename, DenemoGUI * gui,
DenemoSaveType template, Impor
if (xml)
set_gui_filename (gui, filename);
else {
- set_gui_tabname (gui, g_path_get_basename (filename));
+ set_gui_tabname (gui, strip_path_and_extension (filename));
}
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Denemo-devel] memory leak,
Richard Shann <=