denemo-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Denemo-devel] gtk3 branch


From: Richard Shann
Subject: [Denemo-devel] gtk3 branch
Date: Tue, 08 Nov 2011 10:13:49 +0000

Jeremiah,

In your latest check-in:

view.c:three places

you cannot replace the comma operator with a semi-colon

 if((hide && item) || (show && item))\
    ACCUM; activate_action(menu);

the activate_action(menu) here will not be subject to the if condition
which it is with the comma operator.

 if((hide && item) || (show && item))\
    {ACCUM; activate_action(menu)};

would be needed for the same semantics.
alternatively remove the semi-colon from the definition of ACCUM, which
is what is what is forcing your change (the comma operator takes
expressions, by putting a semi-colon in the definition of ACCUM you have
made it a statement)

Richard





reply via email to

[Prev in Thread] Current Thread [Next in Thread]