Re: [Discuss-gnuradio] python scripts in gnuradio-core/src/python/gnuradio/gr inconsistent

[Eric Blossom]

On Sun, Oct 17, 2004 at 04:44:19PM +0930, Berndt Josef Wulf wrote:
> G'day,
> 
> whilst testing gnuradio-core-current (CVS 17/10/2004) the following 
> inconstency were observed and required correction before successfully running 
> the checks:

Thanks.

> The run_tests script will fail due to a syntax error see below:
> 
> --- run_tests.orig      2004-10-17 16:16:04.000000000 +0930
> +++ run_tests   2004-10-17 16:16:16.000000000 +0930
> @@ -17,7 +17,7 @@
>    fi
>  done
> 
> -if [ $ok == yes ]
> +if [ $ok = yes ]
>  then
>    exit 0
>  else

Fixed.  Ahh, POSIX compatibility ;-)

> 
> 
> other files from the same directory with no command instructions are:
> ==> __init__.py <==
> ==> basic_flow_graph.py <==
> ==> exceptions.py <==
> ==> scheduler.py <==
> 
> don't they need the python, if not just for consistency?

These files are not executable (no x bit set).  The are never run from
the command line, only imported into python, thus no #! stuff
On the other hand, the consistency argument makes sense too.  For now
I'll leave them as is.


Thanks for the fixes!
Eric