Re: [Discuss-gnuradio] new to GNUradio: AFSK and codec2 gmsk modem

[Tom Rondeau]

On Tue, Jul 30, 2013 at 6:43 PM, Marcus D. Leech <address@hidden> wrote:
> On 07/30/2013 05:55 PM, Tom Rondeau wrote:
>>
>>
>> So codec2 shouldn't be using Volk, but if it's using some other SIMD
>> code itself, that could be a problem.
>>
>> The problem with just turning off a QA test because it fails is that
>> we're now just hiding a potential problem. I'd rather understand the
>> problem and try and patch it as opposed to shutting our eyes and
>> pretending everything's ok :)
>>
> I agree.   For floating-point-derived "stuff", it seems that tests should
> not be doing bit-wise-exact comparisons (and indeed I think most of
>  our QA tests understand that there's a reasonable "window" for answers
> coming out of the QA tests).

Yes, exactly. The main trouble is finding the balance between handling
these idiosyncrasies and just being sloppy so that anything passes.
But almost never should we require an exact match, especially if
there's any floating point math at all.

-- 
Tom
Visit us at GRCon13 Oct. 1 - 4
http://www.trondeau.com/grcon13