|
From: | Marcus Müller |
Subject: | Re: [Discuss-gnuradio] Include guard bug |
Date: | Fri, 21 Feb 2014 17:58:55 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
Well don't worry, it wasn't actually
causing problems ;)
After fixing, I got out my zsh-foo and tried echo $(( $(git ls-files |grep .h$|xargs git grep --heading "#ifndef INCLUDED"|wc -l) - $(git ls-files |grep .h$|xargs git grep --heading "#ifndef INCLUDED"| uniq | wc -l) )) luckily, there are no duplicate lines containing #ifndef INCLUDED, so I'm hopeful enough everything else is fine in current master. I agree on the #pragma once suggestion, and choose to believe http://en.wikipedia.org/wiki/Pragma_once#Portability which says that we should maybe suggest that people move away from gcc 3.4. Although I don't think this would break a relevant numbers of GNU Radio environments, it could be something maintainers might want to save up for 3.8 or 4 ;) Greetings, Marcus On 02/21/2014 05:32 PM, Tim wrote:
|
[Prev in Thread] | Current Thread | [Next in Thread] |