[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Discuss-gnuradio] Converting from #ifndef/#define include guards to

From: Martin Braun
Subject: Re: [Discuss-gnuradio] Converting from #ifndef/#define include guards to #pragma once globally
Date: Fri, 28 Feb 2014 08:58:52 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

On 02/27/2014 11:42 PM, Marcus Müller wrote:
> As I see things now, I'd just not convert the files to #pragma once.
> However, I do see usefulness in the possibility to analyze headers to
> find 'convertible' include guards, because it is a feasible method of
> ensuring that files don't have erroneous include guards.
> Basically, with a little tweaking my conversion script could be used to
> do some QA on header files (and generate a report, or be run in a
> post-receive hook etc)
> - checking for include guards (are there any headers that shouldn't have
> 'em?)
> - checking for unique include guard names
> - checking if include guards GCC-optimizable.

I think we're already putting more energy into this than it deserves :)
At least for blocks, gr_modtool creates header guards that consist of
the module- and the block name, which you should choose wisely anyway.
Little chance of collisions here.

A script that would check for unique header guards wouldn't hurt. But
what are "optimizable guards"? I think we have much bigger cookies to
bake right now.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]